feat: Take dependencies into account when sorting environment variables#1249
Open
siegfriedweber wants to merge 13 commits into
Open
feat: Take dependencies into account when sorting environment variables#1249siegfriedweber wants to merge 13 commits into
siegfriedweber wants to merge 13 commits into
Conversation
NickLarsenNZ
previously approved these changes
Jul 15, 2026
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
LGTM, but left a comment to check my understanding.
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Techassi
requested changes
Jul 15, 2026
1 task
Techassi
previously approved these changes
Jul 20, 2026
Techassi
left a comment
Techassi
left a comment
Member
There was a problem hiding this comment.
LGTM, just a minor (2-part) suggestion.
Comment on lines
+214
to
+218
| Vec::from(&self) | ||
| .into_iter() | ||
| .cloned() | ||
| .collect::<Vec<_>>() | ||
| .into_iter() |
Member
There was a problem hiding this comment.
Based on the suggestion above, this can be shortened into:
Suggested change
| Vec::from(&self) | |
| .into_iter() | |
| .cloned() | |
| .collect::<Vec<_>>() | |
| .into_iter() | |
| Vec::from(self).into_iter() |
Member
Author
There was a problem hiding this comment.
Your suggestions introduced a call cycle between From<EnvVarSet> for Vec<EnvVar> and IntoIterator for EnvVarSet. I fixed it in de636c0, but the code is not shorter than before.
Co-authored-by: Techassi <git@techassi.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Take dependencies into account when sorting environment variables
For example, the environment variables
are sorted in this order when iterated or converted to a vector:
Part of stackabletech/issues#866
Definition of Done Checklist
Author
Reviewer
Acceptance